➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author rep
Recipients KevinH, alanmcintyre, georg.brandl, ned.deily, r.david.murray, rep, rfk, xuanji
Date 2011-02-10.10:24:37
SpamBayes Score 4.1658944e-07
Marked as misclassified No
Message-id <1297333479.32.0.512937203205.issue10694@psf.upfronthosting.co.za>
In-reply-to
Content 
Xuanji: Patch looks good now with the test cases.

Regarding the other fix suggested by Kevin I think that we should not introduce custom behaviour here like appending the eofdata to the comment even though the comment size in the record does not say so. In the end we want to make sure that correct zip files end up being processed correctly with the specified comment size and incorrect zip files with eofdata should not be rejected / throw exceptions.

So I agree with Xuanji that his patch (or mine) is the way to go.

You probably agree that we can mark issue 10298 to be superseded by this one here.
History
Date User Action Args
2011-02-10 10:24:39repsetrecipients: + rep, georg.brandl, alanmcintyre, ned.deily, r.david.murray, rfk, xuanji, KevinH
2011-02-10 10:24:39repsetmessageid: <1297333479.32.0.512937203205.issue10694@psf.upfronthosting.co.za>
2011-02-10 10:24:37replinkissue10694 messages
2011-02-10 10:24:37repcreate