Message125234
I've added some code comments on http://bugs.python.org/review/7978/show
overall I think the patch is right, I pointed out one thing to clean up and I think the unittest can be greatly simplified by using stubbed out mock select.select() instead of fork+signals+sleeping. |
|
Date |
User |
Action |
Args |
2011-01-03 20:43:17 | gregory.p.smith | set | recipients:
+ gregory.p.smith, spiv, exarkun, pitrou, Christophe Simonis, nvetoshkin, neologix, Yaniv.Aknin, bda, kchen |
2011-01-03 20:43:16 | gregory.p.smith | set | messageid: <1294087396.89.0.712047838587.issue7978@psf.upfronthosting.co.za> |
2011-01-03 20:43:15 | gregory.p.smith | link | issue7978 messages |
2011-01-03 20:43:15 | gregory.p.smith | create | |
|