This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author r.david.murray
Recipients KevinH, alanmcintyre, georg.brandl, ned.deily, r.david.murray, xuanji
Date 2010-12-21.22:44:59
SpamBayes Score 2.7443297e-09
Marked as misclassified No
Message-id <1292971506.51.0.831941745597.issue10694@psf.upfronthosting.co.za>
In-reply-to
Content
Xuanji: thanks for taking a crack at the test.

Rather than adding another data file to the test directory, how about creating a zipfile using the zipfile module in the test, closing it, opening it as a file, writing the /r/n to it, and then opening it back up for read as a zipfile for the test.  That's more parallel to how the other zipfile tests work.

Given what we know I'd be inclined to accept Kevin's suggested fix, unless Alan speaks up against it.  In that case the test may as well check that the comment is what we expect, as well.
History
Date User Action Args
2010-12-21 22:45:06r.david.murraysetrecipients: + r.david.murray, georg.brandl, alanmcintyre, ned.deily, xuanji, KevinH
2010-12-21 22:45:06r.david.murraysetmessageid: <1292971506.51.0.831941745597.issue10694@psf.upfronthosting.co.za>
2010-12-21 22:44:59r.david.murraylinkissue10694 messages
2010-12-21 22:44:59r.david.murraycreate