Message123806
test_pipe_cloexec_unix_tools() is specific to UNIX/BSD because it requires cat and grep programs. You should try to reuse the Python interpreter to have a portable test (eg. working on Windows), as you did with fd_status.py.
+ data = b'aaaaaaaaaaaaaaaaaaaa\n'
+ subdata = b'aaa'
+ assert subdata in data, "Test broken"
Use maybe subdata = data[:3] to avoid an assertion.
I don't understand why do you talk about "atomicity". Do you test add non-atomic operations? Was subprocess atomic?
If I understood correctly, you are fixing a specific issue which can be called something like "subprocess: close pipes on exec(), set FD_CLOEXEC flag to all pipes", and no more changing the default value of close_fds. Can you update the title please? |
|
Date |
User |
Action |
Args |
2010-12-11 17:12:29 | vstinner | set | recipients:
+ vstinner, georg.brandl, gregory.p.smith, paul.moore, ned.deily, milko.krachounov, Giovanni.Bajo |
2010-12-11 17:12:29 | vstinner | set | messageid: <1292087549.13.0.236935835658.issue7213@psf.upfronthosting.co.za> |
2010-12-11 17:12:27 | vstinner | link | issue7213 messages |
2010-12-11 17:12:27 | vstinner | create | |
|