This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author ned.deily
Recipients jackjansen, jvr, mher, ned.deily, ronaldoussoren
Date 2010-12-10.23:25:03
SpamBayes Score 3.760144e-09
Marked as misclassified No
Message-id <1292023507.61.0.393962871298.issue985064@psf.upfronthosting.co.za>
In-reply-to
Content
One review comment: the patch adds a new exception class that is used for the errors that are now additionally detected.  Elsewhere plistlib uses non-specific exception classes like ValueError.  If starting from scratch, it might be better to consistently use a specific exception class but that would create incompatibilities if changed now.  I don't see a compelling need to add one now just for these errors.  (But, if kept, it should be added to the docs.)  Otherwise, looks good to me.

Thanks for taking this on!
History
Date User Action Args
2010-12-10 23:25:07ned.deilysetrecipients: + ned.deily, jackjansen, jvr, ronaldoussoren, mher
2010-12-10 23:25:07ned.deilysetmessageid: <1292023507.61.0.393962871298.issue985064@psf.upfronthosting.co.za>
2010-12-10 23:25:04ned.deilylinkissue985064 messages
2010-12-10 23:25:03ned.deilycreate