Message123758
One review comment: the patch adds a new exception class that is used for the errors that are now additionally detected. Elsewhere plistlib uses non-specific exception classes like ValueError. If starting from scratch, it might be better to consistently use a specific exception class but that would create incompatibilities if changed now. I don't see a compelling need to add one now just for these errors. (But, if kept, it should be added to the docs.) Otherwise, looks good to me.
Thanks for taking this on! |
|
Date |
User |
Action |
Args |
2010-12-10 23:25:07 | ned.deily | set | recipients:
+ ned.deily, jackjansen, jvr, ronaldoussoren, mher |
2010-12-10 23:25:07 | ned.deily | set | messageid: <1292023507.61.0.393962871298.issue985064@psf.upfronthosting.co.za> |
2010-12-10 23:25:04 | ned.deily | link | issue985064 messages |
2010-12-10 23:25:03 | ned.deily | create | |
|