This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author stutzbach
Recipients amaury.forgeotdarc, collinwinter, eric.smith, mark.dickinson, pitrou, rhettinger, stutzbach, terry.reedy, tim.peters
Date 2010-12-01.20:21:41
SpamBayes Score 1.177002e-06
Marked as misclassified No
Message-id <1291234903.41.0.433013647756.issue9915@psf.upfronthosting.co.za>
In-reply-to
Content
Antoine and Raymond, thank you for the valuable feedback.

Attached is a revised version of the patch, which restricts changes to those directly related to moving elements in the keys and values arrays at the same time.  I apologize for having gotten a little carried away with optimizing.

I think I eliminated all of the significant style differences as well.  If you still see glaring style mismatches, please let me know.  It's possible that the differences aren't visible to my eyes. ;-)

http://codereview.appspot.com/3369042/diff/1/Objects/listobject.c

Please let me know what you think of the revised version.
History
Date User Action Args
2010-12-01 20:21:43stutzbachsetrecipients: + stutzbach, tim.peters, collinwinter, rhettinger, terry.reedy, amaury.forgeotdarc, mark.dickinson, pitrou, eric.smith
2010-12-01 20:21:43stutzbachsetmessageid: <1291234903.41.0.433013647756.issue9915@psf.upfronthosting.co.za>
2010-12-01 20:21:41stutzbachlinkissue9915 messages
2010-12-01 20:21:41stutzbachcreate