Message 120023 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	tzot
Recipients	alex, pitrou, rhettinger, terry.reedy, tzot
Date	2010-10-30.21:31:05
SpamBayes Score	2.9034084e-06
Marked as misclassified	No
Message-id	<1288474268.89.0.133993610655.issue10160@psf.upfronthosting.co.za>
In-reply-to

Content
Thank you very much, Antoine, for your review. My comments in reply: - the dead code: it's not dead, IIRC it ensures that at least one argument is given, otherwise it raises an exception. - PyUnicode_GET_SIZE: you're right. The previous patch didn't have this problem, because there were two loops: the first one made sure in advance that all arguments are PyUnicode. - the false comment: right again. A remain from the first patch. - dotted_getattr and references: right! I should have noted better what Raymond's initial loop did. Attached a corrected version of the patch according to Antoine's comments.

Thank you very much, Antoine, for your review. My comments in reply:

- the dead code: it's not dead, IIRC it ensures that at least one argument is given, otherwise it raises an exception.

- PyUnicode_GET_SIZE: you're right. The previous patch didn't have this problem, because there were two loops: the first one made sure in advance that all arguments are PyUnicode.

- the false comment: right again. A remain from the first patch.

- dotted_getattr and references: right! I should have noted better what Raymond's initial loop did.

Attached a corrected version of the patch according to Antoine's comments.

History
Date	User	Action	Args
2010-10-30 21:31:08	tzot	set	recipients: + tzot, rhettinger, terry.reedy, pitrou, alex
2010-10-30 21:31:08	tzot	set	messageid: <1288474268.89.0.133993610655.issue10160@psf.upfronthosting.co.za>
2010-10-30 21:31:07	tzot	link	issue10160 messages
2010-10-30 21:31:06	tzot	create