Message116370
Here's a conservative fix for Python 2.7. It replaces the attempts to call baseclass.method with direct calls to the decorated object (i.e. replace socket.meth(self, ...) with self._sock.meth(...)).
It also corrects a bunch of incorrect arguments being passed to _sock... it's pretty clear this code was not tested. I've added a test that exercises each SSLSocket method that corresponds to a socket._delegate_method.
A nicer solution is to simply make socket.socket actually be a simple subclass of _socket.socket rather than the weird decorator it is now. This has already happened on the py3k branch, which is why it doesn't have this bug. |
|
Date |
User |
Action |
Args |
2010-09-14 06:28:11 | spiv | set | recipients:
+ spiv, pitrou, giampaolo.rodola |
2010-09-14 06:28:10 | spiv | set | messageid: <1284445690.3.0.71258950108.issue9729@psf.upfronthosting.co.za> |
2010-09-14 06:28:09 | spiv | link | issue9729 messages |
2010-09-14 06:28:08 | spiv | create | |
|