➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author lukasz.langa
Recipients Arfrever, BreamoreBoy, agoode, dmalcolm, flox, lukasz.langa, mark.dickinson, pitrou, ronaldoussoren, srid, theller
Date 2010-09-05.13:46:48
SpamBayes Score 2.1574102e-05
Marked as misclassified No
Message-id <5CE08FA9-367C-48A5-8EF9-E1700DFB7ED6@langa.pl>
In-reply-to <1283694286.89.0.107146705576.issue5504@psf.upfronthosting.co.za>
Content 
Please find attached a "fix" for #9662. Some explanation is in order:

- the Windows, Linux and OS X implementations of FFI included in the SVN are different in terms of maturity
- Thomas originally when fixing #5504 used a bit of functionality regarding closures that wasn't there in the Windows and OS X versions
- he did some dirty hacking on the Windows version to make it work: changed the ffi_prep_closure function header to ffi_prep_closure_loc (leaving the old implementation) and introduced names for ffi_closure_alloc and ffi_closure_free
- he didn't touch the OS X version so it failed

I did more-less the same thing but in case of OS X we have many ffi_prep_closure implementations for different archs so I simply did an #ifdef in the place ffi_prep_closure is used.

I think a better solution ultimately would be to update all implementation to FFI 3.0.9 and be done with it. Still, the current patch works for me.
Files
File name Uploaded
issue9662.patch lukasz.langa, 2010-09-05.13:46:47
History
Date User Action Args
2010-09-05 13:46:50lukasz.langasetrecipients: + lukasz.langa, theller, ronaldoussoren, mark.dickinson, pitrou, Arfrever, agoode, srid, flox, dmalcolm, BreamoreBoy
2010-09-05 13:46:49lukasz.langalinkissue5504 messages
2010-09-05 13:46:48lukasz.langacreate