Author asksol
Recipients asksol, gdb, jnoller
Date 2010-07-25.21:33:25
SpamBayes Score 0.0272862
Marked as misclassified No
Message-id <1280093607.19.0.238573406733.issue9205@psf.upfronthosting.co.za>
In-reply-to
Content
> A potential implementation is in termination.patch.  Basically,
> try to shut down gracefully, but if you timeout, just give up and
> kill everything.

You can't have a sensible default timeout, because the worker may be processing something important...

> It's a lot less code (one could write an even shorter patch
> that doesn't try to do any additional graceful error handling),
> doesn't add a new monitor thread, doesn't add any more IPC
> mechanism, etc..  FWIW, I don't see any of these changes as bad,
> but I don't feel like I have a sense of how generally useful they
> would be.

Not everything can be simple. Getting this right may require a bit
of code. I think we can get rid of the ack_handler thread by making
the result handler responsible for both acks and results, but I haven't tried it yet, and this code is already running in production by many so didn't want to change it unless I had to.
History
Date User Action Args
2010-07-25 21:33:27asksolsetrecipients: + asksol, jnoller, gdb
2010-07-25 21:33:27asksolsetmessageid: <1280093607.19.0.238573406733.issue9205@psf.upfronthosting.co.za>
2010-07-25 21:33:25asksollinkissue9205 messages
2010-07-25 21:33:25asksolcreate