➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author amaury.forgeotdarc
Recipients amaury.forgeotdarc, brett.cannon, georg.brandl, tlesher
Date 2010-07-21.21:50:54
SpamBayes Score 0.0018392205
Marked as misclassified No
Message-id <1279749056.23.0.518295966883.issue4510@psf.upfronthosting.co.za>
In-reply-to
Content 
The patch is good, except for two things:
when PyObject_Repr() fails, the word 'item' is put instead. This is a good idea, but PyErr_Clear() should be called as soon as possible, before calling another API function.
Also, the error message can grow without bounds. It would be better to limit the size of the string.
History
Date User Action Args
2010-07-21 21:50:56amaury.forgeotdarcsetrecipients: + amaury.forgeotdarc, brett.cannon, georg.brandl, tlesher
2010-07-21 21:50:56amaury.forgeotdarcsetmessageid: <1279749056.23.0.518295966883.issue4510@psf.upfronthosting.co.za>
2010-07-21 21:50:54amaury.forgeotdarclinkissue4510 messages
2010-07-21 21:50:54amaury.forgeotdarccreate