Message110084
Some comments on the patch:
- shouldn't getdir_id use os.path.normcase() rather than manually switch on `windows`?
- the patch adds lots of names at the top-level which aren't part of the public API ("windows", "getdir_id", "defpath", "defpath_ext"). They should probably start with an underscore.
- if PATH is updated after shutil is first imported, the changes won't get picked up. Is it desired? |
|
Date |
User |
Action |
Args |
2010-07-12 11:47:14 | pitrou | set | recipients:
+ pitrou, edemaine, christian.heimes, ajaksu2, tarek, eric.araujo, Christophe Simonis, andybuckley, tleeuwenburg@gmail.com, michael.foord, brian.curtin, meatballhat, iki |
2010-07-12 11:47:14 | pitrou | set | messageid: <1278935234.53.0.867571365335.issue444582@psf.upfronthosting.co.za> |
2010-07-12 11:47:12 | pitrou | link | issue444582 messages |
2010-07-12 11:47:12 | pitrou | create | |
|