Message108906
Looks pretty good to me, but you may want to doublecheck some of your test criteria.
Firstly, the two "*_with_exception" checks don't look quite right to me. I would have expected to see something like the following for both of them:
self.assertIsNotNone(context.exc)
self.assertIs(context.exc[0], NameError).
Secondly, I can't even begin to guess what the method decoration test is currently trying to show. Why 3 instantiations? Why check the instance assignments rather than the context manager behaviour? Either I'm completely missing something, or this currently isn't testing what you meant to test :)
Finally, you may as well include a second typo test to cover the __enter__ misspelling case. |
|
Date |
User |
Action |
Args |
2010-06-29 14:06:41 | ncoghlan | set | recipients:
+ ncoghlan, michael.foord |
2010-06-29 14:06:41 | ncoghlan | set | messageid: <1277820401.6.0.624407039876.issue9110@psf.upfronthosting.co.za> |
2010-06-29 14:06:40 | ncoghlan | link | issue9110 messages |
2010-06-29 14:06:39 | ncoghlan | create | |
|