Message107385
STINNER Victor wrote:
>
> STINNER Victor <victor.stinner@haypocalc.com> added the comment:
>
>> Since Python3 fixes the UTF-8 default encoding, it's better
>> to enhance PyUnicode_AsUTF8String() to cache the UTF-8
>> string in the Unicode object
>
> Right, that sounds like a great idea. Attached patch implements that: patch PyUnicode_AsUTF8String() and PyUnicode_AsEncodedString(). Does it look ok?
Looks good.
>> replace all uses of _PyUnicode_AsDefaultEncodedString()
>> with PyUnicode_AsUTF8String()
>
> I'm waiting for your approval of the first patch before working on the second part.
When replacing uses of _PyUnicode_AsDefaultEncodedString() with
PyUnicode_AsUTF8String() you have to take great care to decref
the object returned by the latter. Otherwise, we get huge memory
leaks. |
|
Date |
User |
Action |
Args |
2010-06-09 11:14:00 | lemburg | set | recipients:
+ lemburg, vstinner |
2010-06-09 11:13:59 | lemburg | link | issue8923 messages |
2010-06-09 11:13:59 | lemburg | create | |
|