Author belopolsky
Recipients belopolsky, mark.dickinson, rhettinger, stutzbach
Date 2010-05-11.21:18:00
SpamBayes Score 0.000669828
Marked as misclassified No
Message-id <1273612682.8.0.24352779014.issue8692@psf.upfronthosting.co.za>
In-reply-to
Content
I've noticed that your patch changes 

>>> math.factorial(2.**63)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
OverflowError: Python int too large to convert to C long

to

>>> math.factorial(2.**63)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ValueError: factorial() not defined for negative values


While the error message is wrong in both cases, I think OverflowError is a better exception in this case and there should not be a difference between math.factorial(2.**63) and math.factorial(2**63) behavior.
History
Date User Action Args
2010-05-11 21:18:02belopolskysetrecipients: + belopolsky, rhettinger, mark.dickinson, stutzbach
2010-05-11 21:18:02belopolskysetmessageid: <1273612682.8.0.24352779014.issue8692@psf.upfronthosting.co.za>
2010-05-11 21:18:00belopolskylinkissue8692 messages
2010-05-11 21:18:00belopolskycreate