Author daniel.urban
Recipients ajaksu2, daniel.urban, l0nwlf, merwok, r.david.murray, techtonik
Date 2010-05-09.18:13:24
SpamBayes Score 6.20449e-08
Marked as misclassified No
Message-id <1273428809.65.0.966735097516.issue7584@psf.upfronthosting.co.za>
In-reply-to
Content
Here is a new patch.

The name of the optional argument is "default_utcoffset" which is obviously too long, but I can't think a better name. Any suggestions? (I think simply "utcoffset" would be misleading, because the value of the argument is only used for naive instances.)

In Modules/datetimemodule.c (in line 4375) I call Py_INCREF on the PyUnicode instance returned by PyArg_ParseTupleAndKeywords. I'm not sure this is the right thing to do. I'm doing it because the doc says that the reference count of an object returned by PyArg_ParseTupleAndKeywords shouldn't be decremented, and I think PyUnicode_AppendAndDel calls Py_XDECREF on its second argument.
Can anyone correct or confirm me on this? Thanks.
History
Date User Action Args
2010-05-09 18:13:30daniel.urbansetrecipients: + daniel.urban, techtonik, ajaksu2, merwok, r.david.murray, l0nwlf
2010-05-09 18:13:29daniel.urbansetmessageid: <1273428809.65.0.966735097516.issue7584@psf.upfronthosting.co.za>
2010-05-09 18:13:26daniel.urbanlinkissue7584 messages
2010-05-09 18:13:25daniel.urbancreate