Message104772
Thinking about it a bit more, I really would prefer get_range_argument not to steal a reference. If I'm reading a bit of C code and encounter something like:
obj = transform(obj);
if (obj == NULL) ...
my hindbrain immediately starts fretting that something's wrong, and I have to go and ferret out the definition of 'transform' to be sure. In contrast, patterns like:
temp = transform(obj);
Py_DECREF(obj);
obj = temp;
if (obj == NULL) ...
are so common and familiar in the Python codebase that they don't raise the same sort of red flag. |
|
Date |
User |
Action |
Args |
2010-05-02 09:06:15 | mark.dickinson | set | recipients:
+ mark.dickinson, loewis, rhettinger, belopolsky, christian.heimes, josm, robertwb, zanella, akitada |
2010-05-02 09:06:15 | mark.dickinson | set | messageid: <1272791175.18.0.188908807776.issue1533@psf.upfronthosting.co.za> |
2010-05-02 09:06:12 | mark.dickinson | link | issue1533 messages |
2010-05-02 09:06:12 | mark.dickinson | create | |
|