Message103664
New patch, issue2706a.diff, implements timedelta % timedelta and addresses Mark's code review comments.
With respect to Mark's
"""
One other thought: with this division operation added, it might be nice to add constants like td_hour, td_minute, etc. to the module. Then the perennial 'how can I convert my timedelta x to minutes' questions could be answered with 'just do x/td_minute'. I would personally find x/td_second to be a more obvious and natural way to find the total number of seconds in a timedelta than x.total_seconds. I also quite like the idea of being able to create a 2.5-hour timedelta with something like
2*td_hour + 30*td_minute
On the other hand, maybe such constants would just be added clutter, since it's easy to create them when needed.
"""
I dislike this proposal for the same reason as Mark likes it: 2*td_hour + 30*td_minute == timedelta(hours=2, minutes=30) is a violation of TOOWTDI. |
|
Date |
User |
Action |
Args |
2010-04-20 01:23:25 | Alexander.Belopolsky | set | recipients:
+ Alexander.Belopolsky, jribbens, amaury.forgeotdarc, mark.dickinson, vstinner, jess.austin, fredrikj, webograph, eric.araujo, r.david.murray, tleeuwenburg@gmail.com |
2010-04-20 01:23:24 | Alexander.Belopolsky | set | messageid: <1271726604.25.0.649371474887.issue2706@psf.upfronthosting.co.za> |
2010-04-20 01:23:22 | Alexander.Belopolsky | link | issue2706 messages |
2010-04-20 01:23:22 | Alexander.Belopolsky | create | |
|