This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Leak around GetFinalPathNameByHandle (Windows)
Type: resource usage Stage: patch review
Components: Extension Modules, Windows Versions: Python 3.2
process
Status: closed Resolution:
Dependencies: Superseder: os.stat() on windows doesn't consider relative symlink
View: 12084
Assigned To: Nosy List: brian.curtin, jaraco, ocean-city
Priority: normal Keywords: patch

Created on 2010-09-23 15:39 by ocean-city, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
py3k_fix_leak_around_GetFinalPathNameByHandle_v2.patch ocean-city, 2010-12-09 10:47 review
Messages (5)
msg117197 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2010-09-23 15:39
I've found there are leaks around GetFinalPathNameByHandle in
Modules/posixmodule.c. (Leaks when function fails)

I hope attached patch will fix this.
msg117200 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2010-09-23 15:50
I cannot test this directly. Thank you.
msg117205 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2010-09-23 16:14
The tests pass here, but I haven't thoroughly reviewed the patch yet. After a quick glance it generally looks ok, although I wish we didn't have so much duplication.
msg123675 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2010-12-09 10:47
This is updated version. Can you test this?
(I only fixed leak, deferred other fixes to future)
msg136063 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2011-05-16 02:58
I'll close this entry because #12084 contains this fix.
History
Date User Action Args
2022-04-11 14:57:06adminsetgithub: 54136
2011-05-16 02:58:51ocean-citysetstatus: open -> closed
superseder: os.stat() on windows doesn't consider relative symlink
messages: + msg136063
2010-12-09 10:47:53ocean-citysetfiles: - py3k_fix_leak_around_GetFinalPathNameByHandle.patch
2010-12-09 10:47:31ocean-citysetfiles: + py3k_fix_leak_around_GetFinalPathNameByHandle_v2.patch

messages: + msg123675
2010-09-23 16:14:35brian.curtinsetmessages: + msg117205
2010-09-23 15:50:05ocean-citysetmessages: + msg117200
2010-09-23 15:48:21brian.curtinsetnosy: + jaraco, brian.curtin

type: resource usage
components: + Extension Modules
stage: patch review
2010-09-23 15:47:26ocean-citysetmessages: - msg117199
2010-09-23 15:46:48ocean-citysetmessages: + msg117199
2010-09-23 15:39:07ocean-citycreate