In Python 3.1, xdrlib.Packer().pack_fstring() throws a TypeError if called with a str() (an encoded string bytes() works just fine).

>>> xdrlib.Packer().pack_fstring(6, "foobar")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.1/xdrlib.py", line 81, in pack_fstring
    data = data + (n - len(data)) * b'\0'
TypeError: Can't convert 'bytes' object to str implicitly

Thanks for the report. Can you tell if it applies to 3.2? Also, is the doc unclear on this point?

Editing type. (FYI, you can follow the link to see some descriptions.)

It will apply to 3.2 also, checking in SVN there have been no changes to xdrlib.py for a couple of years.

The documentation makes no mention of the need to encode strings.

Here is a simple patch with a test. Depending o bytes in this library seems strange, maybe it should be changed somehow? Anyway, this simple patch should be a quick fix to the problem.

This doesn't really make sense, since XDR doesn't seem to say anything about unicode strings, just bytes.

Actually documentation doesn't say that it supports only bytes, but:

"The following methods support packing strings, bytes, and opaque data:"

Also under python2 you can easily do this:

In [1]: import xdrlib

In [2]: p = xdrlib.Packer()

In [3]: p.pack_string('some str')

In [4]: p.pack_string(u'some str')

So to conclude I believe either docs for python3 should be changed to say that only bytes are allowed or it should be changed to work as in python2. It's clear that in python2 some unicode string are accepted and I think we should allow such strings to be accepted in python3 too.

2011/4/14 Filip Gruszczyński <report@bugs.python.org>:
>
> Filip Gruszczyński <gruszczy@gmail.com> added the comment:
>
> Actually documentation doesn't say that it supports only bytes, but:
>
> "The following methods support packing strings, bytes, and opaque data:"
>
> Also under python2 you can easily do this:
>
> In [1]: import xdrlib
>
> In [2]: p = xdrlib.Packer()
>
> In [3]: p.pack_string('some str')
>
> In [4]: p.pack_string(u'some str')

I doubt u"美", will, though.

I am well aware of this, Benjamin. I am not trying to force any solution, but rather trying to point out, that current documentation is misleading. There might be no need for patching the code, but rather updating the docs to say, that only bytes are allowed and that will be sufficient.

2011/4/14 Filip Gruszczyński <report@bugs.python.org>:
>
> Filip Gruszczyński <gruszczy@gmail.com> added the comment:
>
> I am well aware of this, Benjamin. I am not trying to force any solution, but rather trying to point out, that current documentation is misleading. There might be no need for patching the code, but rather updating the docs to say, that only bytes are allowed and that will be sufficient.

Yes, I think a doc patch is the correct thing to do.

I'll provide docs patch.