Created on 2010-07-24 09:53 by neXyon, last changed 2010-10-02 23:25 by Trundle.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| patch.diff | neXyon, 2010-07-24 10:02 | patch | review | |
| Messages (5) | |||
|---|---|---|---|
| msg111437 - (view) | Author: Jörg Müller (neXyon) | Date: 2010-07-24 09:53 | |
Patch attached |
|||
| msg111439 - (view) | Author: Jörg Müller (neXyon) | Date: 2010-07-24 10:02 | |
I've merged the patch with the changes from Armin in issue9368. |
|||
| msg117887 - (view) | Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) *  |
Date: 2010-10-02 17:05 | |
Martin, what do you think about this kind of changes? Are there possible regressions or incompatibilities? |
|||
| msg117888 - (view) | Author: Martin v. Löwis (loewis) * |
Date: 2010-10-02 17:09 | |
AFAICT, they are compatible, so +1. The typical proposition of an incompatible change either proposes to use const char* as the return type, or has multi-level pointers that are proposed to be constified. |
|||
| msg117889 - (view) | Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * |
Date: 2010-10-02 17:14 | |
Thanks for the confirmation! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2010-10-02 23:25:19 | Trundle | set | nosy:
+ Trundle |
| 2010-10-02 17:14:35 | amaury.forgeotdarc | set | resolution: accepted messages: + msg117889 |
| 2010-10-02 17:09:35 | loewis | set | messages: + msg117888 |
| 2010-10-02 17:05:06 | amaury.forgeotdarc | set | nosy:
+ amaury.forgeotdarc, loewis messages: + msg117887 |
| 2010-07-24 11:17:49 | eric.araujo | set | nosy:
+ aronacher stage: commit review |
| 2010-07-24 11:16:57 | eric.araujo | link | issue9368 superseder |
| 2010-07-24 10:02:48 | neXyon | set | files: - patch.diff |
| 2010-07-24 10:02:19 | neXyon | set | files:
+ patch.diff type: enhancement -> behavior messages: + msg111439 |
| 2010-07-24 09:53:20 | neXyon | create | |