Created on 2010-07-23 18:58 by John.Chandler, last changed 2010-12-31 19:32 by r.david.murray. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| test_calendar.diff | John.Chandler, 2010-07-23 18:58 | review | ||
| Messages (3) | |||
|---|---|---|---|
| msg111373 - (view) | Author: John Chandler (John.Chandler) | Date: 2010-07-23 18:58 | |
Hi, Attaching a patch for the test_calendar.py file. Adds four tests to provide coverage of the leapdays() function. John |
|||
| msg124969 - (view) | Author: Sandro Tosi (sandro.tosi) *  |
Date: 2010-12-31 17:23 | |
I just tried John's patch, and: - it still applies without problem (except for a bit of offset) - I can confirm that it actually adds test coverage for leapdays() function (bringing calendar coverage from 71% to 72%). I think it would be good to apply it to py3k branch. Cheers, Sandro |
|||
| msg124974 - (view) | Author: R. David Murray (r.david.murray) * |
Date: 2010-12-31 19:32 | |
Applied in r87590. I threw in an extra test for a multi-leapyear-range. Since there was no reason not to, I backported it to 3.1 in r87591 and 2.7 in r87592. In the latter two commits I also backported the issue 9342 patch. Thanks for the patch, John, and for the review, Sandro. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2010-12-31 19:32:43 | r.david.murray | set | status: open -> closed nosy: + r.david.murray versions: + Python 3.1, Python 2.7 messages: + msg124974 resolution: accepted stage: patch review -> committed/rejected |
| 2010-12-31 17:23:12 | sandro.tosi | set | nosy:
+ sandro.tosi messages: + msg124969 stage: patch review |
| 2010-07-23 18:58:41 | John.Chandler | create | |