This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Py3k compilation on old MSVC
Type: Stage: resolved
Components: Build Versions: Python 3.2
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: brian.curtin, georg.brandl, loewis, ocean-city
Priority: normal Keywords: patch

Created on 2010-07-21 05:49 by ocean-city, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
py3k_compile_on_old_compiler.patch ocean-city, 2010-07-21 05:49
Messages (5)
msg111007 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2010-07-21 05:49
Hello. Attached patch is needed to compile on MSVC6. I'm appriciated
if this patch is accepted.
msg113545 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2010-08-10 16:11
PC/pyconfig.h: no more needed. fixed in posixmodule.c
Python/import.c: my patch was wrong. we should use _mkdir(const char*)
on windows. there is deprecated function mkdir(const char*), but it
doesn't take mode_t as parameter. so maybe it is unsafe to call with mkdir(dirpath, dirmode) on windows.
msg115983 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2010-09-10 06:57
Patch for import.c was checked in (#9752), so last piece is just patch
for Include/pythread.h. I'll commit this near future. I believe this is
not problematic.
msg116122 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2010-09-11 21:21
I agree.
msg116127 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2010-09-11 22:36
Thank you, fixed in r84724(py3k).
History
Date User Action Args
2022-04-11 14:57:04adminsetgithub: 53564
2010-09-11 22:36:25ocean-citysetstatus: open -> closed
versions: - Python 3.1
messages: + msg116127

assignee: ocean-city ->
resolution: accepted -> fixed
stage: patch review -> resolved
2010-09-11 21:21:36georg.brandlsetresolution: accepted

messages: + msg116122
nosy: + georg.brandl
2010-09-10 06:57:21ocean-citysetassignee: ocean-city
messages: + msg115983
2010-08-10 16:11:08ocean-citysetmessages: + msg113545
2010-07-21 13:00:37r.david.murraysetnosy: + loewis, brian.curtin
2010-07-21 05:49:05ocean-citycreate