➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2010-06-13 21:15 by vstinner, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| getarg_err_occurred.patch | vstinner, 2010-06-13 21:15 | review | ||
| Messages (3) | |||
|---|---|---|---|
| msg107753 - (view) | Author: STINNER Victor (vstinner) *  |
Date: 2010-06-13 21:15 | |
If convertitem() result is not NULL, an error occured and seterror() is called (by the function calling convertitem()). seterror() does nothing if an exception was raised (if PyErr_Occurred() is non zero). convertitem() doesn't need to call converterr() if an exception occurred because the string formatted by converterr() will be ignored. We just need to return a non NULL pointer: msgbuf. Attached patch creates a RETURN_ERR_OCCURRED macro. convertsimple() should be a little bit faster and the code is more readable. Details: - addcleanup() now takes a boolean to indicate if it's a buffer or a pointer to simplify the API and have to raise a special error if the destructor is unknown - don't check that the result of PyUnicode_AsEncodedString() is a bytes object: PyUnicode_AsEncodedString() does already check that |
|||
| msg125307 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2011-01-04 11:16 | |
Fixed by r87732 |
|||
| msg125308 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2011-01-04 11:17 | |
(and by r87731) |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:02 | admin | set | github: 53238 |
| 2011-01-04 11:17:10 | vstinner | set | messages: + msg125308 |
| 2011-01-04 11:16:58 | vstinner | set | status: open -> closed messages: + msg125307 resolution: fixed |
| 2010-06-13 21:15:30 | vstinner | create | |