classification
Title: PyArg_ParseTuple(): remove old and unused "O?" format
Type: Stage:
Components: Interpreter Core Versions: Python 3.2
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: haypo, mark.dickinson
Priority: normal Keywords: patch

Created on 2010-05-27 22:59 by haypo, last changed 2010-05-28 21:55 by haypo. This issue is now closed.

Files
File name Uploaded Description Edit
getarg_oquestion.patch haypo, 2010-05-27 22:59
Messages (2)
msg106624 - (view) Author: STINNER Victor (haypo) * (Python committer) Date: 2010-05-27 22:59
"O?" format was introduced by r4301 (15 years, 9 months ago). PyArg_ParseTuple() was first documented in Python 2.2, but without the full list of all formats. The format list was added to Python 2.3, but "O?" was never documented. So I get that no third party progam use it.

In Python trunk, "O?" is no more used and so I propose to remove it to simplify getarg.c (simplify getarg cannot be a bad thing). PyArg_ParseTuple() has now better formats than "O?".

--

"O&" calls a callback: if the callback returns 0, raise an error; otherwise gets the object. Example of callbacks: PyXXX_Check() function (eg. PyInt_Check()).

--

The full Python test suite pass without any error on a patched Python (trunk).
msg106692 - (view) Author: STINNER Victor (haypo) * (Python committer) Date: 2010-05-28 21:55
Commited: r81588 (py3k), blocked in 3.1 (r81589).
History
Date User Action Args
2010-05-28 21:55:57hayposetstatus: open -> closed
resolution: fixed
messages: + msg106692
2010-05-27 23:02:51hayposetversions: - Python 2.7
2010-05-27 23:00:07hayposetnosy: + mark.dickinson
2010-05-27 22:59:39haypocreate