This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: regrtest: add a minimal "progress bar"
Type: Stage:
Components: Versions: Python 3.1, Python 3.2, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: ezio.melotti, georg.brandl, pitrou, r.david.murray, vstinner
Priority: normal Keywords: patch

Created on 2010-04-28 17:01 by vstinner, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
regrtest_progress-py3k.patch vstinner, 2010-04-28 17:01
Messages (8)
msg104440 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2010-04-28 17:01
regrtest takes between 10 and 20 minutes to run the full test suite. It would be nice to see the progress of the test suite with a kind of progress bar. Add the test number would be enough:

$ ./python Lib/test/regrtest.py                             
...
test_grammar (1/340)                                             
test_opcodes (2/340)                                             
test_dict (3/340)                                                
test_builtin (4/340)                                             
test_exceptions (5/340)                                          
test_types (6/340)                                               
test_unittest (7/340)                                            
...

Attached patch implements that (classic version and multiprocess version).
msg104534 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2010-04-29 16:08
-1

IMO it just makes the output messier and less readable, and I personally am fine with judging the progress by the filenames.
msg104602 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2010-04-30 00:30
> I personally am fine with judging the progress by the filenames

The new displayed test names only inform you that regrtest is not blocked, but you don't know how many tests remain if:
 - you use -j option (which shuffle the list at little bit)
 - you use -r (random): I think that the buildbots use them. If a buildbot hang, it's not easy to see how many tests were executed (and how many remain)
 - you specify a list of test names on the command line
msg104603 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2010-04-30 00:33
Higher/lower bounds for me:
 - Quad core @ 2.5 GHz with -j4: 2 min 40 sec
 - Pentium4 @ 3 GHz (hyperthreading) without -j: 11 min 21 sec

Sometimes I forget to use -j, and sometimes I cannot use it (eg. see my last patches to support --without-threads ;-)).

When it takes more than 30 seconds, I would like a progress bar to estimate (myself) the remaing time :-)
msg105178 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2010-05-07 00:16
Most developer are opposed to this feature, so I close this issue.
msg109859 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2010-07-10 12:16
Hmm, I see only one objection...  and I think readability will be much less affected if the format is

[  1/340] test_grammar
[  2/340] test_opcodes
[  3/340] test_dict

or somesuch.
msg109863 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2010-07-10 12:29
Georg's suggestion is rather nice.
msg112514 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2010-08-02 19:00
Committed patch adding the [x/y] style indicator in r83543.
History
Date User Action Args
2022-04-11 14:57:00adminsetgithub: 52806
2010-08-02 19:00:07georg.brandlsetstatus: open -> closed
resolution: fixed
messages: + msg112514
2010-07-10 14:43:16ezio.melottisetnosy: + ezio.melotti
2010-07-10 12:29:35pitrousetnosy: + pitrou

messages: + msg109863
versions: + Python 3.1
2010-07-10 12:16:46georg.brandlsetstatus: closed -> open

nosy: + georg.brandl
messages: + msg109859

resolution: not a bug -> (no value)
2010-05-07 00:16:22vstinnersetstatus: open -> closed
resolution: not a bug
messages: + msg105178
2010-04-30 00:33:07vstinnersetmessages: + msg104603
2010-04-30 00:30:25vstinnersetmessages: + msg104602
2010-04-29 16:08:01r.david.murraysetnosy: + r.david.murray
messages: + msg104534
2010-04-28 17:01:41vstinnercreate