Created on 2010-04-24 17:27 by brian.curtin, last changed 2010-09-27 17:57 by brian.curtin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue8521.diff | brian.curtin, 2010-08-25 01:55 | py3k patch | ||
| Messages (5) | |||
|---|---|---|---|
| msg104120 - (view) | Author: Daniel Stutzbach (stutzbach)  |
Date: 2010-04-24 19:16 | |
Hi Brian, It looks like you had attached to issue5774 a patch to allow OpenKey to accept keyword arguments. Just thought I'd mention that here so there's a link back to it. |
|||
| msg104126 - (view) | Author: Brian Curtin (brian.curtin) * |
Date: 2010-04-24 19:52 | |
Here's an expanded version of that patch to include two newer functions, plus docs and test. The doc might need work on those signatures -- there was some discussion on IRC about how keyword arguments should be documented. |
|||
| msg104127 - (view) | Author: Brian Curtin (brian.curtin) * |
Date: 2010-04-24 19:53 | |
Forgot to attach the patch... |
|||
| msg114873 - (view) | Author: Brian Curtin (brian.curtin) * |
Date: 2010-08-25 01:55 | |
Attached is a better patch which, I think, uses better names. CreateKeyEx, OpenKeyEx, and DeleteKeyEx (x64 only) all take named arguments. key, sub_key, reserved, and access are the names of the arguments. The tests run Create and Open regardless, but use DeleteKey or DeleteKeyEx depending on architecture. I think the docs correctly denote what was changed here. Adding Amaury since he suggested these name changes on #5774. |
|||
| msg117454 - (view) | Author: Brian Curtin (brian.curtin) * |
Date: 2010-09-27 17:57 | |
Committed in r85033. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2010-09-27 17:57:28 | brian.curtin | set | status: open -> closed resolution: fixed messages: + msg117454 stage: patch review -> committed/rejected |
| 2010-08-25 01:55:40 | brian.curtin | set | files:
+ issue8521.diff title: Allow some winreg functions to accept keyword arguments -> Allow some winreg functions to accept named arguments nosy: + amaury.forgeotdarc messages: + msg114873 |
| 2010-08-25 01:50:42 | brian.curtin | set | files: - issue8521.diff |
| 2010-04-24 19:53:54 | brian.curtin | set | files:
+ issue8521.diff keywords: + patch messages: + msg104127 |
| 2010-04-24 19:52:56 | brian.curtin | set | messages:
+ msg104126 stage: needs patch -> patch review |
| 2010-04-24 19:16:41 | stutzbach | set | nosy:
+ stutzbach messages: + msg104120 |
| 2010-04-24 17:27:08 | brian.curtin | create | |