This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: regrtest should check for changes in import machinery
Type: enhancement Stage: needs patch
Components: Tests Versions: Python 3.2
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: brett.cannon Nosy List: brett.cannon, flox
Priority: low Keywords: easy

Created on 2010-02-07 21:56 by brett.cannon, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (2)
msg99024 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2010-02-07 21:56
The saved_test_environment context manager should check that sys.path_hooks, sys.path_importer_cache, and __import__ have not changed.

The thing that is tricky, though, is that sys.path_importer_cache is legitimately mutated by other tests simply because valid imports put in new values. The most conservative check, then, is to validate that pre-existing keys do not change their values. A more liberal check is to whitelist finders and validate that no key have a value that is not on the whitelist.

And for __import__, assigning against __builtins__.__import__ should be enough to also catch builtins.__import__.
msg99574 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2010-02-19 15:58
Committed to py3k in r78241.
History
Date User Action Args
2022-04-11 14:56:57adminsetgithub: 52126
2010-02-19 15:58:39brett.cannonsetstatus: open -> closed
resolution: fixed
messages: + msg99574
2010-02-08 19:39:32floxsetnosy: + flox
2010-02-07 21:56:17brett.cannoncreate