Created on 2009-12-28 14:30 by exarkun, last changed 2010-02-10 15:54 by michael.foord. This issue is now closed.
| Messages (6) | |||
|---|---|---|---|
| msg96948 - (view) | Author: Jean-Paul Calderone (exarkun) *  |
Date: 2009-12-28 14:30 | |
Sometime between Python 2.6 and 2.7a1, the unittest.TestCase.shortDescription method changed from returning just the test method name to the test method name, in parentheses, the fully qualified Python name of the test case. This breaks several Twisted unit tests and, I think, goes against the expectations users have of the "shortDescription" method. |
|||
| msg96953 - (view) | Author: Michael Foord (michael.foord) * |
Date: 2009-12-28 15:07 | |
Personally I agree. I'll see if I can find the change (don't think it was me) and see if there was some kind of rationale. |
|||
| msg97000 - (view) | Author: Brian Curtin (brian.curtin) * |
Date: 2009-12-29 19:18 | |
It looks like this was changed in r70837 |
|||
| msg98917 - (view) | Author: Michael Foord (michael.foord) * |
Date: 2010-02-05 23:00 | |
The problem this fix was trying to fix was that if you provide a docstring for your test then the test name is ommitted in the report. This could be fixed in the _TextTestResult instead - changing the getDescription() method to always include str(test). |
|||
| msg98932 - (view) | Author: Jean-Paul Calderone (exarkun) * |
Date: 2010-02-06 04:15 | |
I agree that changing the result object is a better way to implement this feature: if the results object wants to report things by *name*, not *description*, then it should get the test's *name*, not rely on changing the meaning of the test's description method. |
|||
| msg99168 - (view) | Author: Michael Foord (michael.foord) * |
Date: 2010-02-10 15:54 | |
Fixed revision 78130. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2010-02-10 15:54:43 | michael.foord | set | status: open -> closed resolution: accepted messages: + msg99168 stage: needs patch -> committed/rejected |
| 2010-02-06 12:07:03 | michael.foord | set | nosy:
+ gregory.p.smith |
| 2010-02-06 04:15:28 | exarkun | set | messages: + msg98932 |
| 2010-02-05 23:00:21 | michael.foord | set | messages: + msg98917 |
| 2010-01-13 05:22:47 | ezio.melotti | set | nosy:
+ ezio.melotti |
| 2010-01-13 03:01:08 | brian.curtin | set | stage: needs patch |
| 2009-12-29 21:23:23 | brett.cannon | set | assignee: michael.foord |
| 2009-12-29 19:18:21 | brian.curtin | set | nosy:
+ brian.curtin messages: + msg97000 |
| 2009-12-28 15:07:27 | michael.foord | set | messages: + msg96953 |
| 2009-12-28 14:46:13 | r.david.murray | set | priority: normal nosy: + michael.foord |
| 2009-12-28 14:30:40 | exarkun | create | |