This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: doc: patch for Doc/faq/design.rst
Type: Stage: patch review
Components: Documentation Versions: Python 3.1, Python 3.2, Python 2.7, Python 2.6
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: ezio.melotti Nosy List: ezio.melotti, flox, georg.brandl, pitrou
Priority: normal Keywords: patch

Created on 2009-12-13 19:05 by flox, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
doc_faq_design.diff flox, 2009-12-18 18:54 Patch, apply to trunk
doc_faq_design_py3k.diff flox, 2009-12-18 18:55 Patch, apply to py3k
doc_faq_design_py3k_missing.diff flox, 2009-12-19 20:39 Patch, apply to py3k r76895
Messages (7)
msg96345 - (view) Author: Florent Xicluna (flox) * (Python committer) Date: 2009-12-13 19:05
I reviewed the documentation and tested the examples with Python 3.

I found many parts which are changed or irrelevant.
Here is the patch.
msg96573 - (view) Author: Florent Xicluna (flox) * (Python committer) Date: 2009-12-18 18:54
Updated patch with suggestions of Ezio.
msg96623 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2009-12-19 17:46
Thanks, committed in r76886, r76887.
msg96645 - (view) Author: Florent Xicluna (flox) * (Python committer) Date: 2009-12-19 20:39
Commit r76886 on Python 2.7 is fine.

But the patch is not merged completly on branches/py3k.

I prepared a new patch against py3k to fix what is missing.
msg96648 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2009-12-19 21:16
I saw two small things:
- dict.has_key is still used instead of `in`
- Pyrex is mentioned, but not Cython (http://www.cython.org/); Cython is
probably much more active than Pyrex, though.
msg96651 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2009-12-19 21:30
> I saw two small things:
> - dict.has_key is still used instead of `in`

Florent pointed to me that it's not true. I was watching a stale
version, sorry.
msg96683 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2009-12-20 14:25
Thanks, applied in r76923.

For future patches, please use notes sparingly, and warnings even more
so.  Not every sentences starting with "Note that..." needs to be a
Note.  Also, Notes should contain whole sentences (i.e. the first word
is uppercased).
History
Date User Action Args
2022-04-11 14:56:55adminsetgithub: 51742
2009-12-20 14:25:35georg.brandlsetstatus: open -> closed

messages: + msg96683
2009-12-19 21:30:16pitrousetmessages: + msg96651
2009-12-19 21:16:27pitrousetnosy: + pitrou
messages: + msg96648
2009-12-19 20:40:01floxsetstatus: closed -> open
files: + doc_faq_design_py3k_missing.diff
messages: + msg96645
2009-12-19 17:46:53georg.brandlsetstatus: open -> closed
resolution: accepted
messages: + msg96623
2009-12-18 18:55:29floxsetfiles: + doc_faq_design_py3k.diff
2009-12-18 18:55:02floxsetfiles: + doc_faq_design.diff

title: doc: patch for py3k/Doc/faq/design.rst -> doc: patch for Doc/faq/design.rst
messages: + msg96573
versions: + Python 2.6, Python 2.7
2009-12-18 18:49:48floxsetfiles: - py3k_doc_faq_design.diff
2009-12-18 17:51:51ezio.melottisetassignee: georg.brandl -> ezio.melotti
2009-12-13 19:21:45ezio.melottisetnosy: + ezio.melotti
2009-12-13 19:19:38ezio.melottisetpriority: normal
stage: patch review
2009-12-13 19:05:18floxcreate