This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Unsupported provider

classification
Title: Document changes in asynchat
Type: enhancement Stage: resolved
Components: Documentation Versions: Python 3.4, Python 3.5, Python 2.7
process
Status: closed Resolution: out of date
Dependencies: Superseder:
Assigned To: josiahcarlson Nosy List: CuriousLearner, ezio.melotti, georg.brandl, giampaolo.rodola, jramnani, lehmannro
Priority: normal Keywords: patch

Created on 2009-09-14 15:26 by lehmannro, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
asynchat-docs.patch lehmannro, 2009-09-14 15:26 patch to Doc/library/asynchat.rst review
asynchat-docs.patch lehmannro, 2009-09-14 15:38 patch #2 to Doc/library/asynchat.rst review
asynchat-docs.patch lehmannro, 2009-09-15 05:31 patch #3 to Doc/library/asynchat.rst review
asynchat-docs.patch jramnani, 2011-03-14 15:34 Update for patch #3 to Doc/library/asynchat.rst review
Messages (6)
msg92616 - (view) Author: Robert Lehmann (lehmannro) * Date: 2009-09-14 15:26
asynchat.async_chat grew a _collect_incoming and a _get_data method in
2.6. The constructor has been extended to conform to
asyncore.dispatcher's. This should be documented.

Apart from that, fifo and simple_producer have been deprecated, and
async_chat.ac_out_buffer was replaced by async_chat.incoming. These are
internals and were never documented.

A patch is attached.
msg92617 - (view) Author: Robert Lehmann (lehmannro) * Date: 2009-09-14 15:38
Excuse me -- fifo and simple_producer are indeed documented and need a
deprecation notice. New patch attached (plus reworded paragraph about
async_chat.__init__).
msg92644 - (view) Author: Robert Lehmann (lehmannro) * Date: 2009-09-15 05:31
I found another bug: async_chat.push still talks about automatically
creating a simple_producer, which is no longer true. 

I added a fix to the patch.
msg130829 - (view) Author: Jeff Ramnani (jramnani) * Date: 2011-03-14 15:34
This patch could no longer be applied cleanly on the 2.7 branch.

I have updated the patch so it applies cleanly to commit 22f991bb9b0b on the 2.7 branch.
msg220658 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2014-06-15 18:12
Is it worth applying the latest patch given that asynchat is deprecated in favour of asyncio?
msg341397 - (view) Author: Sanyam Khurana (CuriousLearner) * (Python triager) Date: 2019-05-04 19:05
Given that Python 2.x and async chat is deprecated in favor of new async io, we're better in closing this issue, rather than trying to apply this cleanly on the master branch.
History
Date User Action Args
2022-04-11 14:56:53adminsetgithub: 51160
2019-05-04 19:05:51CuriousLearnersetstatus: open -> closed

nosy: + CuriousLearner
messages: + msg341397

resolution: out of date
stage: patch review -> resolved
2019-05-02 04:15:24josiahcarlsonsetnosy: - josiahcarlson
2019-03-15 22:38:07BreamoreBoysetnosy: - BreamoreBoy
2015-03-01 23:53:28BreamoreBoysetversions: + Python 3.5, - Python 3.2, Python 3.3
2014-06-15 18:12:11BreamoreBoysetnosy: + BreamoreBoy
messages: + msg220658
2012-10-02 05:31:38ezio.melottisetnosy: + ezio.melotti
stage: patch review
type: enhancement

versions: + Python 3.3, Python 3.4, - Python 2.6, Python 3.0, Python 3.1
2011-03-14 15:34:16jramnanisetfiles: + asynchat-docs.patch
nosy: + jramnani
messages: + msg130829

2009-12-09 21:29:08giampaolo.rodolasetnosy: + giampaolo.rodola
2009-09-15 05:31:42lehmannrosetfiles: + asynchat-docs.patch

messages: + msg92644
2009-09-14 15:38:47lehmannrosetfiles: + asynchat-docs.patch

messages: + msg92617
2009-09-14 15:30:57georg.brandlsetassignee: georg.brandl -> josiahcarlson

nosy: + josiahcarlson
2009-09-14 15:26:58lehmannrocreate