classification
Title: Document changes in asynchat
Type: enhancement Stage: patch review
Components: Documentation Versions: Python 3.4, Python 3.3, Python 3.2, Python 2.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: josiahcarlson Nosy List: ezio.melotti, georg.brandl, giampaolo.rodola, josiahcarlson, jramnani, lehmannro
Priority: normal Keywords: patch

Created on 2009-09-14 15:26 by lehmannro, last changed 2012-10-02 05:31 by ezio.melotti.

Files
File name Uploaded Description Edit
asynchat-docs.patch lehmannro, 2009-09-14 15:26 patch to Doc/library/asynchat.rst review
asynchat-docs.patch lehmannro, 2009-09-14 15:38 patch #2 to Doc/library/asynchat.rst review
asynchat-docs.patch lehmannro, 2009-09-15 05:31 patch #3 to Doc/library/asynchat.rst review
asynchat-docs.patch jramnani, 2011-03-14 15:34 Update for patch #3 to Doc/library/asynchat.rst review
Messages (4)
msg92616 - (view) Author: Robert Lehmann (lehmannro) * Date: 2009-09-14 15:26 
asynchat.async_chat grew a _collect_incoming and a _get_data method in
2.6. The constructor has been extended to conform to
asyncore.dispatcher's. This should be documented.

Apart from that, fifo and simple_producer have been deprecated, and
async_chat.ac_out_buffer was replaced by async_chat.incoming. These are
internals and were never documented.

A patch is attached.
msg92617 - (view) Author: Robert Lehmann (lehmannro) * Date: 2009-09-14 15:38 
Excuse me -- fifo and simple_producer are indeed documented and need a
deprecation notice. New patch attached (plus reworded paragraph about
async_chat.__init__).
msg92644 - (view) Author: Robert Lehmann (lehmannro) * Date: 2009-09-15 05:31 
I found another bug: async_chat.push still talks about automatically
creating a simple_producer, which is no longer true. 

I added a fix to the patch.
msg130829 - (view) Author: Jeff Ramnani (jramnani) * Date: 2011-03-14 15:34 
This patch could no longer be applied cleanly on the 2.7 branch.

I have updated the patch so it applies cleanly to commit 22f991bb9b0b on the 2.7 branch.
History
Date User Action Args
2012-10-02 05:31:38ezio.melottisetnosy: + ezio.melotti
stage: patch review
type: enhancement

versions: + Python 3.3, Python 3.4, - Python 2.6, Python 3.0, Python 3.1
2011-03-14 15:34:16jramnanisetfiles: + asynchat-docs.patch
nosy: + jramnani
messages: + msg130829

2009-12-09 21:29:08giampaolo.rodolasetnosy: + giampaolo.rodola
2009-09-15 05:31:42lehmannrosetfiles: + asynchat-docs.patch

messages: + msg92644
2009-09-14 15:38:47lehmannrosetfiles: + asynchat-docs.patch

messages: + msg92617
2009-09-14 15:30:57georg.brandlsetassignee: georg.brandl -> josiahcarlson

nosy: + josiahcarlson
2009-09-14 15:26:58lehmannrocreate