test/test_telnetlib.py has zero tests for the telnetlib.Telnet.write method.

Marking as easy.  What needs to be done is to add a small fake socket
class that redefines socket.sendall(self, bytes) to capture the args to
sock.sendall so it can be assertEqual'd to the expected bytes.

class SocketSendall(socket.socket):
  _raw_sent = b''
  def sendall(self, data):
    self._raw_sent += data

class TelnetSockSendall(telnetlib.Telnet):
  def open(self, *args, **opts):
    ''' a near-exact copy of Telnet.open '''
    # copy 5 lines from Telnet.open here
    self.sock = SocketSendall(*args, **opts)

then add a unit test that checks the ONLY thing Telnet.write() does,
which is change IAC to IAC+IAC.

Did only minor modifications to TelnetSocketSendall class.

Please review the following patch.

Thanks Rodrigo,  I'll integrate this and check it in.

applied in r74638
and I've added you to Misc/ACKS
Thanks again for the patch!

On Thu, 03 Sep 2009 20:38:49 +0000
Jack Diederich <report@bugs.python.org> wrote:

> 
> Jack Diederich <jackdied@gmail.com> added the comment:
> 
> applied in r74638
> and I've added you to Misc/ACKS
> Thanks again for the patch!

No problem,

Anything I can do to improve telnetlib further?

I'm currently with plenty of time available and would appreciate the
opportunity to learn more Python.

Rodrigo

> ----------
> resolution:  -> accepted
> status: open -> closed
> 
> _______________________________________
> Python tracker <report@bugs.python.org>
> <http://bugs.python.org/issue6582>
> _______________________________________