Logged In: YES
user_id=11105
There is no need to review the patches, as it seems, nobody
needs this and the PEP will be rejected.
Discussion of the patches:
One thing is missing in pep298.core.patch, a change should
probably be made to PyType_Ready(), so that
Py_TPFLAGS_HAVE_GETCHARBUFFER is set when
Py_TPFLAGS_HAVE_LOCKEDBUFFER is present.
arraymodule.patch: A diffferent error should probably be
raised when the array object cannot be resized because it is
locked, currently the patch uses PyExc_RuntimeError.
|