➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2009-07-03 13:50 by alejolp, last changed 2022-04-11 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| 2to3-os.path.sep.path | alejolp, 2009-07-03 13:50 | |||
| Messages (3) | |||
|---|---|---|---|
| msg90055 - (view) | Author: Alejandro Santos (alejolp) | Date: 2009-07-03 13:50 | |
The 2to3 tool shipped with Python 3.1 final doesn't handle correctly a local package import (fixer fix_import). Test case: $ find . -name '*.py' ./__init__.py ./a.py ./b/__init__.py ./b/m.py $ 2to3 a.py RefactoringTool: Skipping implicit fixer: buffer RefactoringTool: Skipping implicit fixer: idioms RefactoringTool: Skipping implicit fixer: set_literal RefactoringTool: Skipping implicit fixer: ws_comma RefactoringTool: No files need to be modified. $ cat a.py from b import m m.q() Trying to use the 2to3 tool from one level up won't work either: $ 2to3 test2to3/a.py RefactoringTool: Skipping implicit fixer: buffer RefactoringTool: Skipping implicit fixer: idioms RefactoringTool: Skipping implicit fixer: set_literal RefactoringTool: Skipping implicit fixer: ws_comma RefactoringTool: No files need to be modified. It seems to be a bug in the fixer, which is using the os.path.pathsep constant when it should be using the os.path.sep instead. The probably_a_local_import function is checking if "test2to3/b:" exists, when it should be checking against: "test2to3/b/" Attached patch seems to be working: $ 2to3 test2to3/a.py RefactoringTool: Skipping implicit fixer: buffer RefactoringTool: Skipping implicit fixer: idioms RefactoringTool: Skipping implicit fixer: set_literal RefactoringTool: Skipping implicit fixer: ws_comma --- test2to3/a.py (original) +++ test2to3/a.py (refactored) @@ -1,5 +1,5 @@ -from b import m +from .b import m m.q() RefactoringTool: Files that need to be modified: RefactoringTool: test2to3/a.py |
|||
| msg90057 - (view) | Author: Benjamin Peterson (benjamin.peterson) *  |
Date: 2009-07-03 14:03 | |
Fixed in r73811. |
|||
| msg90058 - (view) | Author: Alejandro Santos (alejolp) | Date: 2009-07-03 14:04 | |
Nice, Thanks! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:56:50 | admin | set | github: 50657 |
| 2009-07-03 14:04:50 | alejolp | set | messages: + msg90058 |
| 2009-07-03 14:03:35 | benjamin.peterson | set | status: open -> closed nosy: + benjamin.peterson messages: + msg90057 resolution: fixed |
| 2009-07-03 13:50:35 | alejolp | create | |