classification
Title: TCP Sockets not closed by TCPServer and StreamRequestHandler
Type: behavior Stage:
Components: Library (Lib) Versions: Python 2.7
process
Status: closed Resolution:
Dependencies: Superseder: Cumulative patcc:h to http and xmlrpc
View: 6267
Assigned To: Nosy List: krisvale
Priority: normal Keywords: needs review, patch

Created on 2009-06-09 16:55 by krisvale, last changed 2009-06-28 21:14 by krisvale. This issue is now closed.

Files
File name Uploaded Description Edit
socketserver.patch krisvale, 2009-06-09 16:55
Messages (1)
msg89152 - (view) Author: Kristján Valur Jónsson (krisvale) * Date: 2009-06-09 16:55 
When an error occurs in a StreamRequestHandler, its wfile and rfile 
members are not closed.  This causes the underlaying socket to stay 
alive and and it is therefore not closed, even when the SocketServer 
closes it in server.close_request().  This means that a client will not 
know that there is no one listening on the other end.

This is due to incorrect error handling semantics in BaseRequestHandler.

This patch fixes the error handling in BaseRequestHandler, ensuring that 
request.finish() is called when request.setup() has completed.

I also add an explicit socket.shutdown() in TCPServer.close_request() to 
make sure that at least a half-close occurs even in the face of socket 
reference leaks.
History
Date User Action Args
2009-06-28 21:14:13krisvalesetstatus: open -> closed
keywords: patch, patch, needs review
superseder: Cumulative patcc:h to http and xmlrpc
2009-06-09 16:55:37krisvalecreate