classification
Title: Tkinter.Scrollbar: the activate method needs to return a value, and set should take only two args
Type: behavior Stage: patch review
Components: Tkinter Versions: Python 3.3, Python 3.2, Python 2.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: gpolo
Priority: normal Keywords: patch

Created on 2009-06-01 20:11 by gpolo, last changed 2011-11-29 06:09 by ezio.melotti.

Files
File name Uploaded Description Edit
Scrollbar_fixes.diff gpolo, 2009-06-01 20:11 review
Messages (2)
msg88670 - (view) Author: Guilherme Polo (gpolo) * (Python committer) Date: 2009-06-01 20:11
Hi,

I've noticed some minor problems in Tkinter.Scrollbar that would be good
to be addressed. The activate method never returns a value and it also
doesn't accept to be called without an element -- which is accepted by
tcl. When an element is not especified, the current active element
should be returned. It's signature is also a bit strange, I don't see
why it has a parameter named "index" while it never takes an index but
an element.

The second problem is about the set method. It accepts any amount of
arguments, but it only needs to accept two. Passing a tuple in the form
of (number, number) to it isn't accepted, so I don't see much reason to
continue with an *args there.
msg112865 - (view) Author: Mark Lawrence (BreamoreBoy) Date: 2010-08-04 19:08
A tiny patch, can someone take a look with a view to committing, thanks.
History
Date User Action Args
2011-11-29 06:09:07ezio.melottisetnosy: - BreamoreBoy

versions: + Python 3.3, - Python 3.1
2010-08-04 19:08:57BreamoreBoysetversions: + Python 3.2
nosy: + BreamoreBoy

messages: + msg112865

type: behavior
stage: patch review
2009-06-01 20:11:31gpolocreate