classification
Title: Tkinter.Text: changes for bbox, debug, and edit methods.
Type: behavior Stage: patch review
Components: Tkinter Versions: Python 3.2, Python 3.1, Python 2.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: BreamoreBoy, gpolo
Priority: normal Keywords: patch

Created on 2009-05-31 20:06 by gpolo, last changed 2010-08-01 08:20 by BreamoreBoy.

Files
File name Uploaded Description Edit
tkinter_text_changes.diff gpolo, 2009-05-31 20:06 review
Messages (2)
msg88607 - (view) Author: Guilherme Polo (gpolo) * (Python committer) Date: 2009-05-31 20:06
Hi,

While testing Tkinter.Text I've found some problems and it would be good
to fix them in trunk.

The methods edit_redo, edit_reset, edit_separator and edit_undo doesn't
return anything, so I would suggest to remove the return statements there.
The debug method doesn't return a boolean when we set a value for the
debug option, so the getboolean function fails:

>>> import Tkinter
>>> text = Tkinter.Text()
>>> text.debug()
False
>>> text.debug(1)
...
_tkinter.TclError: expected boolean value but got ""


I'm also suggesting a change in the bbox signature. Right now it
supports receiving multiple args, but the bbox command in Tcl expects a
single item as the index. I believe it makes more sense to indicate that
it accepts a single argument. An index like '1.0 +1c' needs to either be
passed as '1.0 +1c' or ('1.0', '+1c') (a tuple holding the two parts),
not as '1.0', '+1c' (two arguments).
msg112287 - (view) Author: Mark Lawrence (BreamoreBoy) Date: 2010-08-01 08:20
The suggested changes are mostly trivial, but there should be comments on the change to the bbox signature.
History
Date User Action Args
2010-08-01 08:20:34BreamoreBoysetversions: + Python 3.2
nosy: + BreamoreBoy

messages: + msg112287

type: behavior
stage: patch review
2009-05-31 20:06:12gpolocreate