This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: POP_MARK was not in pickle protocol 0
Type: behavior Stage: patch review
Components: Library (Lib) Versions: Python 3.1, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: collinwinter Nosy List: alexandre.vassalotti, collinwinter
Priority: low Keywords: easy, patch

Created on 2009-05-20 01:31 by collinwinter, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
pickletools.patch collinwinter, 2009-05-20 01:31
Messages (3)
msg88105 - (view) Author: Collin Winter (collinwinter) * (Python committer) Date: 2009-05-20 01:31
Lib/pickletools.py incorrectly thinks POP_MARK was part of protocol 0;
POP_MARK was only added with the introduction of protocol 1 in r7753.
This mistake led me down a dead end while fixing another pickling issue.

Alexandre, can you double-check me on this? Feel free to bounce this
back if you don't have time.

I'll port this to py3k. I'm leaning toward a backport to 2.6; any
thoughts on that?
msg88106 - (view) Author: Alexandre Vassalotti (alexandre.vassalotti) * (Python committer) Date: 2009-05-20 04:05
SHORT_BINBYTES needs to be corrected as well; pickletools lists it as
part of protocol 0 instead of protocol 3.

I doubt backporting this patch to 2.6 will cause any trouble. So, you
can go forward with this.
msg88133 - (view) Author: Collin Winter (collinwinter) * (Python committer) Date: 2009-05-20 19:05
Applied in r72792 (trunk), r72793 (py3k), r72808 (release26-maint).
History
Date User Action Args
2022-04-11 14:56:49adminsetgithub: 50316
2009-05-20 19:05:43collinwintersetstatus: open -> closed
assignee: collinwinter
resolution: fixed
messages: + msg88133
2009-05-20 04:05:43alexandre.vassalottisetmessages: + msg88106
2009-05-20 01:31:12collinwintercreate