This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_urllib failures on the 3.1 buildbots
Type: behavior Stage: needs patch
Components: Versions: Python 3.0, Python 3.1
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: ajaksu2, benjamin.peterson, kristjan.jonsson, pitrou
Priority: critical Keywords:

Created on 2009-02-07 22:47 by pitrou, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (6)
msg81353 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2009-02-07 22:47
This failure happens on all 3.x buildbots:

======================================================================
ERROR: test_empty_socket (test.test_urllib.urlopen_HttpTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/test/test_urllib.py",
line 194, in test_empty_socket
    self.assertRaises(IOError, urlopen, "http://something")
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/unittest.py", line
344, in failUnlessRaises
    callableObj(*args, **kwargs)
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/test/test_urllib.py",
line 33, in urlopen
    return opener.open(url)
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/urllib/request.py", line
1444, in open
    return getattr(self, name)(url)
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/urllib/request.py", line
1618, in open_http
    return self._open_generic_http(http.client.HTTPConnection, url, data)
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/urllib/request.py", line
1601, in _open_generic_http
    response = http_conn.getresponse()
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/http/client.py",
line 937, in getresponse
    method=self._method)
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/http/client.py",
line 275, in __init__
    self.fp = sock.makefile("rb")
TypeError: makefile() takes exactly 3 positional arguments (2 given)

======================================================================
ERROR: test_read (test.test_urllib.urlopen_HttpTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/test/test_urllib.py",
line 168, in test_read
    fp = urlopen("http://python.org/")
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/test/test_urllib.py",
line 33, in urlopen
    return opener.open(url)
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/urllib/request.py", line
1444, in open
    return getattr(self, name)(url)
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/urllib/request.py", line
1618, in open_http
    return self._open_generic_http(http.client.HTTPConnection, url, data)
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/urllib/request.py", line
1601, in _open_generic_http
    response = http_conn.getresponse()
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/http/client.py",
line 937, in getresponse
    method=self._method)
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/http/client.py",
line 275, in __init__
    self.fp = sock.makefile("rb")
TypeError: makefile() takes exactly 3 positional arguments (2 given)

======================================================================
ERROR: test_read_bogus (test.test_urllib.urlopen_HttpTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/test/test_urllib.py",
line 185, in test_read_bogus
    self.assertRaises(IOError, urlopen, "http://python.org/")
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/unittest.py", line
344, in failUnlessRaises
    callableObj(*args, **kwargs)
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/test/test_urllib.py",
line 33, in urlopen
    return opener.open(url)
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/urllib/request.py", line
1444, in open
    return getattr(self, name)(url)
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/urllib/request.py", line
1618, in open_http
    return self._open_generic_http(http.client.HTTPConnection, url, data)
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/urllib/request.py", line
1601, in _open_generic_http
    response = http_conn.getresponse()
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/http/client.py",
line 937, in getresponse
    method=self._method)
  File
"/home/pybot/buildarea/3.x.klose-debian-ppc/build/Lib/http/client.py",
line 275, in __init__
    self.fp = sock.makefile("rb")
TypeError: makefile() takes exactly 3 positional arguments (2 given)
msg81354 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2009-02-07 22:56
Fixed in r69416.
msg81355 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2009-02-07 23:40
Now test_docxmlrpc fails and test_httpservers times out...
msg81356 - (view) Author: Daniel Diniz (ajaksu2) * (Python triager) Date: 2009-02-07 23:44
Benjamin,
r69416 breaks at least test_docxmlrpc and test_httplib, and hangs on
test_httpservers (Gentoo, Debian ppc, OSX buildbots show it).
msg81358 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2009-02-08 00:29
Apparently, I don't know what I'm doing. reverted in r69418.
msg81370 - (view) Author: Kristján Valur Jónsson (kristjan.jonsson) * (Python committer) Date: 2009-02-08 10:27
I was going to fix this, but Nick Coghlan beat me to it in r69429
History
Date User Action Args
2022-04-11 14:56:45adminsetgithub: 49431
2009-02-08 10:27:22kristjan.jonssonsetstatus: open -> closed
resolution: fixed
messages: + msg81370
2009-02-08 00:29:46benjamin.petersonsetstatus: closed -> open
resolution: fixed -> (no value)
messages: + msg81358
2009-02-07 23:44:07ajaksu2setnosy: + ajaksu2
messages: + msg81356
2009-02-07 23:40:56pitrousetmessages: + msg81355
2009-02-07 22:56:01benjamin.petersonsetstatus: open -> closed
resolution: fixed
messages: + msg81354
nosy: + benjamin.peterson
2009-02-07 22:47:37pitroucreate