classification
Title: os.fdopen doesn't raise on invalid file descriptors
Type: behavior Stage:
Components: Library (Lib) Versions: Python 3.0, Python 3.1
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, pitrou
Priority: normal Keywords: patch

Created on 2009-01-18 21:02 by benjamin.peterson, last changed 2009-01-19 15:14 by benjamin.peterson. This issue is now closed.

Files
File name Uploaded Description Edit
raise_on_bad_fd.patch benjamin.peterson, 2009-01-18 21:54
raise_on_bad_fd2.patch benjamin.peterson, 2009-01-18 23:52
Messages (8)
msg80125 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2009-01-18 21:02
Since os.fdopen is now implemented with io.open, it doesn't use fdopen
and check for invalid file descriptors. This isn't a huge issue since
subsequent actions on the file will raise an error.
msg80128 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2009-01-18 21:23
Perhaps io.open should be fixed, then?
(or the _FileIO constructor)
msg80130 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2009-01-18 21:54
Here's a patch for _FileIO.
msg80135 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2009-01-18 23:21
I think EBADF is defined everywhere, so you can drop the defined()
conditional.
msg80136 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2009-01-18 23:52
Attaching new patch...
msg80137 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2009-01-19 00:03
I'm not sure Windows has a valid fstat btw, I'll guess we'll see on the
Windows buildbots (in that case, some code can be taken from
posixmodule.c to emulate fstat behaviour...). Other than that, the patch
looks fine to me.
msg80138 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2009-01-19 00:09
Applied in r68755. Will watch Windows.
msg80176 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2009-01-19 15:14
Well, the Windows bot is failing but not from test_fileio, so I'll go
ahead and merge it. r68767.
History
Date User Action Args
2009-01-19 15:14:38benjamin.petersonsetmessages: + msg80176
2009-01-19 00:09:38benjamin.petersonsetstatus: open -> closed
resolution: fixed
messages: + msg80138
2009-01-19 00:03:53pitrousetmessages: + msg80137
2009-01-18 23:52:22benjamin.petersonsetfiles: + raise_on_bad_fd2.patch
messages: + msg80136
2009-01-18 23:21:51pitrousetmessages: + msg80135
2009-01-18 21:54:49benjamin.petersonsetfiles: + raise_on_bad_fd.patch
keywords: + patch
messages: + msg80130
2009-01-18 21:23:42pitrousetnosy: + pitrou
messages: + msg80128
2009-01-18 21:02:02benjamin.petersoncreate