This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: urlparse & nfs url (rfc 2224)
Type: enhancement Stage:
Components: Extension Modules Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: orsenthil Nosy List: jhylton, jjlee, orsenthil, yuhl
Priority: normal Keywords: patch

Created on 2009-01-16 10:28 by yuhl, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
issue4962-py27.diff orsenthil, 2009-03-30 21:35
issue4962-py3k.diff orsenthil, 2009-03-30 21:35
Messages (6)
msg79946 - (view) Author: Cédric BRINER (yuhl) Date: 2009-01-16 10:28
Hi,

I'd like to add the ability to parse nfs url (rfc2224). Which look like:
nfs://server/my/path

To do this, we only need to add 'nfs' in uses_netloc to make it work

cEd
msg79950 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2009-01-16 10:43
> I'd like to add the ability to parse nfs url (rfc2224). Which look like:
> nfs://server/my/path
>
> To do this, we only need to add 'nfs' in uses_netloc to make it work

Do you encounter any errors or weird behaviors while using nfs url?
The RFC2224 for NFS just says it is for local  and network files and
in turn uses specification in RFC 1738 "Uniform Resource Locators".
So, I don't think any problem or breakage should occur with NFS

('nfs', '', '//server//a/b/c/d/e/f', '', '', '')

If you have done the research already, can you please explain what
difference will adding 'nfs' to uses_netloc do in urlparse.py.
msg80150 - (view) Author: Cédric BRINER (yuhl) Date: 2009-01-19 09:50
> Do you encounter any errors or weird behaviors while using nfs url?

Do you mean: Do I have problem using the python module in conjunction of
urlparse ?
No, because, I'm not yet using it. But I would like to do it. And I find
it strange that it can not find the host by itself.

>('nfs', '', '//server//a/b/c/d/e/f', '', '', '')
>If you have done the research already, can you please explain what
>difference will adding 'nfs' to uses_netloc do in urlparse.py.

As much as I've looked at the code, the uses_netloc provide an easy way
to tell urlparse.py if such scheme as nfs is composed
by a net location (host[:port]). Which is the case. Modifying
uses_netloc by addind 'nfs' into it will transform the following:
nfsurl : 'nfs://server//a/b/c/d/e/f'
in  urlparse from:
('nfs', '', '//server//a/b/c/d/e/f', '', '', '')
to
('nfs', 'server', '//a/b/c/d/e/f', '', '', '')
msg84656 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2009-03-30 21:34
Patch to fix this. Looked into the RFCs and I do not find a reason why
the nfs://server/path/to/file.txt should not be parsed as:

>>> urlparse.urlsplit('nfs://server/path/to/file.txt')
SplitResult(scheme='nfs', netloc='server', path='/path/to/file.txt',
query='', fragment='')

Patch and Tests added.
msg84658 - (view) Author: Jeremy Hylton (jhylton) (Python triager) Date: 2009-03-30 21:40
looks good to me
msg84671 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2009-03-30 22:02
fixed.
History
Date User Action Args
2022-04-11 14:56:44adminsetgithub: 49212
2009-03-30 22:51:37orsenthilsetstatus: open -> closed
2009-03-30 22:02:06orsenthilsetassignee: orsenthil
resolution: fixed
messages: + msg84671
2009-03-30 21:40:09jhyltonsetnosy: + jhylton
messages: + msg84658
2009-03-30 21:35:21orsenthilsetfiles: + issue4962-py3k.diff
2009-03-30 21:35:08orsenthilsetfiles: + issue4962-py27.diff
keywords: + patch
2009-03-30 21:34:51orsenthilsetmessages: + msg84656
2009-02-13 01:46:31ajaksu2setnosy: + jjlee
2009-01-19 09:50:08yuhlsetmessages: + msg80150
2009-01-16 10:43:07orsenthilsetnosy: + orsenthil
messages: + msg79950
2009-01-16 10:28:24yuhlcreate