This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Remove checks for win NT
Type: enhancement Stage:
Components: Interpreter Core Versions: Python 3.2, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ocean-city Nosy List: amaury.forgeotdarc, eckhardt, loewis, ocean-city
Priority: normal Keywords: patch

Created on 2009-01-06 08:55 by eckhardt, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
python-2.7-win9x-wchar-checks.0.patch eckhardt, 2009-01-06 12:17 patch
remove_w9x_code.patch ocean-city, 2009-06-21 10:07
remove_unused_function.patch ocean-city, 2009-06-29 09:57
Messages (14)
msg79237 - (view) Author: Ulrich Eckhardt (eckhardt) Date: 2009-01-06 08:55
There are several checks like "GetVersion() < 0x80000000" that try to 
determine whether there is support for the WCHAR versions of the win32 
API. Since all support for MS Windows 95, 98 and ME has been dropped, 
all supported systems support those APIs. Also, I need that cleanup as 
preparation for porting Python to MS Windows CE, so that I don't have 
to clone/port code for obsolete systems there. I'll be providing 
patches here.
msg79249 - (view) Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * (Python committer) Date: 2009-01-06 11:55
+1
msg79252 - (view) Author: Ulrich Eckhardt (eckhardt) Date: 2009-01-06 12:17
This patch removes all calls to win32's GetVersion() where they are used
to detect NT. In posixmodule.c it was used by a wrapper function that
cached the result, which then also became obsolete.
msg79306 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2009-01-07 08:47
+1. I've tested this patch on win2k & vc6, and worked correctly.
msg87960 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2009-05-17 06:08
The patch is slightly out of date; if updated, it is fine to apply after
3.1.

I think Py_GetFileAttributesExA can also be removed.
msg89559 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2009-06-21 10:07
Here is an updated patch with Py_GetFileAttributesEx[AW] removal.
I propose to commit this to trunk, and merge it to py3k after 3.1 will
be released.
msg89570 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2009-06-21 18:28
I think it's easier if the patch just sits here for six more days; 3.1
won't take much longer.
msg89765 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2009-06-28 05:19
OK, 3.1 was out. Can I commit this to trunk and merge it to py3k?
msg89766 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2009-06-28 07:37
Sure, go ahead.
msg89774 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2009-06-28 11:08
Thanks, committed in r73603(trunk) and r73604(py3k).
msg89820 - (view) Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * (Python committer) Date: 2009-06-29 08:13
The functions Py_GetFileAttributesExA and Py_GetFileAttributesExW were
not removed. Is it intended?
msg89823 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2009-06-29 09:57
Oops, sorry. This function is not needed if GetFileAttributesEx never
fail with ERROR_CALL_NOT_IMPLEMENTED. I believe this won't happen on win
NT. How about this patch?
msg89825 - (view) Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * (Python committer) Date: 2009-06-29 11:09
Yes, that's what I had in mind.
msg89826 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2009-06-29 11:39
Thanks, committed in r73675(trunk) and r73676(py3k).
History
Date User Action Args
2022-04-11 14:56:43adminsetgithub: 49106
2009-06-29 11:39:23ocean-citysetstatus: open -> closed

messages: + msg89826
2009-06-29 11:09:28amaury.forgeotdarcsetmessages: + msg89825
2009-06-29 09:57:57ocean-citysetfiles: + remove_unused_function.patch

messages: + msg89823
2009-06-29 08:13:13amaury.forgeotdarcsetstatus: closed -> open
assignee: ocean-city
messages: + msg89820
2009-06-28 11:08:24ocean-citysetstatus: open -> closed
resolution: fixed
messages: + msg89774
2009-06-28 07:37:25loewissetmessages: + msg89766
2009-06-28 05:19:49ocean-citysetmessages: + msg89765
versions: + Python 3.2
2009-06-21 18:28:21loewissetmessages: + msg89570
2009-06-21 10:08:14ocean-citysetfiles: + remove_w9x_code.patch

messages: + msg89559
2009-05-17 06:08:22loewissetmessages: + msg87960
2009-05-17 05:42:53ocean-citysetnosy: + loewis
2009-01-07 08:47:45ocean-citysetnosy: + ocean-city
messages: + msg79306
2009-01-06 12:17:11eckhardtsetfiles: + python-2.7-win9x-wchar-checks.0.patch
keywords: + patch
messages: + msg79252
2009-01-06 11:55:02amaury.forgeotdarcsetnosy: + amaury.forgeotdarc
messages: + msg79249
2009-01-06 08:55:47eckhardtcreate