This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_binascii is failing
Type: Stage:
Components: Extension Modules Versions: Python 3.0
process
Status: closed Resolution: fixed
Dependencies: Superseder: test_binascii fails on windows
View: 4542
Assigned To: loewis Nosy List: amaury.forgeotdarc, loewis, rhettinger
Priority: normal Keywords:

Created on 2008-12-04 03:15 by rhettinger, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (3)
msg76864 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2008-12-04 03:15
test_binascii.py fails because crc32 accepts a string.

From my WindowsXP box:

C:\Python30>python \python30\lib\test\test_binascii.py
test_base64invalid (__main__.BinASCIITest) ... ok
test_base64valid (__main__.BinASCIITest) ... ok
test_crc32 (__main__.BinASCIITest) ... ok
test_empty_string (__main__.BinASCIITest) ... ok
test_exceptions (__main__.BinASCIITest) ... ok
test_functions (__main__.BinASCIITest) ... ok
test_hex (__main__.BinASCIITest) ... ok
test_no_binary_strings (__main__.BinASCIITest) ... FAIL
test_qp (__main__.BinASCIITest) ... ok
test_uu (__main__.BinASCIITest) ... ok

======================================================================
FAIL: test_no_binary_strings (__main__.BinASCIITest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "\python30\lib\test\test_binascii.py", line 177, in
test_no_binary_strings
    self.assertRaises(TypeError, f, "test")
AssertionError: TypeError not raised by crc32

----------------------------------------------------------------------
Ran 10 tests in 0.016s

FAILED (failures=1)
Traceback (most recent call last):
  File "\python30\lib\test\test_binascii.py", line 183, in <module>
    test_main()
  File "\python30\lib\test\test_binascii.py", line 180, in test_main
    support.run_unittest(BinASCIITest)
  File "C:\Python30\lib\test\support.py", line 698, in run_unittest
    _run_suite(suite)
  File "C:\Python30\lib\test\support.py", line 681, in _run_suite
    raise TestFailed(err)
test.support.TestFailed: Traceback (most recent call last):
  File "\python30\lib\test\test_binascii.py", line 177, in
test_no_binary_strings
    self.assertRaises(TypeError, f, "test")
AssertionError: TypeError not raised by crc32
msg76874 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2008-12-04 07:12
The problem is that the Windows implementation of crc32 is different
from the Unix implementation, and that implementation was missed in
r67472. The fix should be fairly trivial.
msg76965 - (view) Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * (Python committer) Date: 2008-12-05 01:44
I fixed this in r67541 and r67542, with issue4542.
(sorry I did not see this one)
History
Date User Action Args
2022-04-11 14:56:42adminsetgithub: 48764
2008-12-05 01:44:06amaury.forgeotdarcsetstatus: open -> closed
resolution: fixed
superseder: test_binascii fails on windows
messages: + msg76965
nosy: + amaury.forgeotdarc
2008-12-04 07:12:35loewissetmessages: + msg76874
2008-12-04 03:15:19rhettingercreate