classification
Title: httplib code thinks it closes connection, but does not
Type: behavior Stage:
Components: Library (Lib) Versions: Python 3.0, Python 2.7, Python 2.6
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: jjlee (1)
Priority: Keywords

Created on 2008-12-02 18:15 by jjlee, last changed 2008-12-02 18:15 by jjlee.

Messages (1)
msg76764 - (view) Author: John J Lee (jjlee) Date: 2008-12-02 18:15 
The fix for #900744 tried to close the connection when a bad chunk
length was received.  The comment inserted with that fix "close the
connection as protocol synchronisation is probably lost" is incorrect:
self.close() in _read_chunked does not close the connection.  You have
to call HTTPConnection.close() to close the connection.

So:

 * The comment is incorrect, and should be removed or fixed.  I guess
the self.close() should stay.

 * It's probably a bug that it doesn't result in the connection being
closed.  I guess a fix for that would be for the HTTPResponse to set
some state on itself that HTTPConnection can query so that
HTTPConnection can close itself the next time somebody tries to do
something with the connection.
History
Date User Action Args
2008-12-02 18:15:19jjleecreate