This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: from __future__ import division
Type: Stage:
Components: Interpreter Core Versions:
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: gvanrossum
Priority: normal Keywords: patch

Created on 2001-07-22 04:21 by gvanrossum, last changed 2022-04-10 16:04 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
divpatch2.txt gvanrossum, 2001-07-31 19:33 revised patch per revised PEP 238 (including graminit.c)
Messages (3)
msg37051 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2001-07-22 04:21
This patch is a quick hack to implement one way of
doing PEP 238 (non-integer division).

There are two parts to it.

Part 1: the // operator implements integer division.

Part 2: when "from __future__ import division" is
in effect, the / operator implements float division.

The //= and /= operators are also affected.
(This is part of why I chose // over the keyword 'div';
also because that would require a new keyword.)

The implementation now has three division operations
(of each variation: regular and inplace, and
corresponding opcodes) where it used to have one:

- Division for / without future statement
- FloatDivision for / with future statement
- IntDivision for //

The actual implementations for IntDivision and
FloatDivision are a bit lame:

- (old) Division is unchanged (using nb_division)
- IntDivision just calls Division, so only does the
  right thing for ints and longs
- FloatDivision adds 0.0 to the second operand

At some point in the future, to keep NumPy happy,
the "as number" struct should grow extra slots
for the additional operations, and the above
operations should only be used as fallbacks.
(Maybe the fallback for IntDivision should use
the nb_divmod slot as fallback.)

Enjoy!
msg37052 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2001-07-22 04:39
Logged In: YES 
user_id=6380

Note, the patch doesn't include the changes for graminit.c
(because they were big).  This may cause problems on
Windows, where that file is not automatically recreated when
the grammar changes.

I'm including the new graminit.c just in case.  (graminit.h
is unchanged.)
msg37053 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2001-07-31 19:33
Logged In: YES 
user_id=6380

Uploading a new version.  This includes the patch for graminit.c.
This follows the revised PEP: terminology changed to true and floor division,
actual slots in type objects used.
History
Date User Action Args
2022-04-10 16:04:13adminsetgithub: 34804
2001-07-22 04:21:08gvanrossumcreate