➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test with pickle.HIGHEST_PROTOCOL missing
Type: Stage:
Components: Tests Versions: Python 3.0, Python 3.1, Python 2.7, Python 2.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, ocean-city
Priority: normal Keywords: easy, patch

Created on 2008-10-23 00:11 by ocean-city, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
test_with_HIGHEST_PROTOCOL_on_trunk.patch ocean-city, 2008-10-23 00:11 trunk
test_with_HIGHEST_PROTOCOL_on_py3k.patch ocean-city, 2008-10-23 00:19 py3k
Messages (4)
msg75125 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2008-10-23 00:11 
some tests use "for proto in range(pickle.HIGHEST_PROTOCOL)", but this
statement won't invoke proto == pickle.HIGHEST_PROTOCOL. Is this
intended? If not, I hope attached patch will fix this issue.
msg75127 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-10-23 00:27 
That lots reasonable to me.
msg75128 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-10-23 00:27 
s/lots/looks/
msg75130 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2008-10-23 00:39 
Thanks, I committed in r67002(trunk) and r67003(py3k).
History
Date User Action Args
2022-04-11 14:56:40adminsetgithub: 48433
2008-10-23 00:39:19ocean-citysetstatus: open -> closed
resolution: fixed
messages: + msg75130
2008-10-23 00:27:55benjamin.petersonsetmessages: + msg75128
2008-10-23 00:27:38benjamin.petersonsetnosy: + benjamin.peterson
messages: + msg75127
2008-10-23 00:19:04ocean-citysetkeywords: + easy
files: + test_with_HIGHEST_PROTOCOL_on_py3k.patch
2008-10-23 00:11:32ocean-citycreate