Created on 2008-10-19 12:10 by djmdjm, last changed 2008-10-19 14:15 by benjamin.peterson. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| patch-Modules_python_c | djmdjm, 2008-10-19 12:10 | explicitly cast PyMem_Malloc return | ||
| Messages (3) | |||
|---|---|---|---|
| msg74973 - (view) | Author: Damien Miller (djmdjm) | Date: 2008-10-19 12:10 | |
Compilation of 3.0rc1 Modules/python.c fails on OpenBSD with the following error. The attached patch fixes things by explicitly casting PyMem_Malloc's return value c++ -pthread -c -fno-strict-aliasing -DNDEBUG -O2 -pipe -DTHREAD_STACK_SIZE=0x20000 -fPIC -I. -IInclude -I./Include -DPy_BUILD_CORE -o Modules/python.o ./Modules/python.c Modules/python.c: In function `int main(int, char**)': Modules/python.c:20: error: invalid conversion from `void*' to `wchar_t**' Modules/python.c:22: error: invalid conversion from `void*' to `wchar_t**' Modules/python.c:57: error: invalid conversion from `void*' to `wchar_t*' |
|||
| msg74974 - (view) | Author: Christian Heimes (christian.heimes) *  |
Date: 2008-10-19 12:19 | |
Thanks! The patch looks good. Next time please use either the .diff or .patch extension. It makes it easier to review the patch. |
|||
| msg74975 - (view) | Author: Benjamin Peterson (benjamin.peterson) * |
Date: 2008-10-19 14:15 | |
Fixed in r66976. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2008-10-19 14:15:50 | benjamin.peterson | set | status: open -> closed resolution: accepted -> fixed messages: + msg74975 nosy: + benjamin.peterson |
| 2008-10-19 12:19:21 | christian.heimes | set | nosy:
+ barry, christian.heimes messages: + msg74974 priority: release blocker assignee: barry keywords: + patch, needs review resolution: accepted |
| 2008-10-19 12:10:32 | djmdjm | create | |