classification
Title: Fix caching in ABCMeta.__subclasscheck__
Type: Stage:
Components: Versions: Python 3.0, Python 2.6
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: andrewmcnamara, georg.brandl, ncoghlan
Priority: release blocker Keywords: needs review, patch

Created on 2008-09-01 10:04 by ncoghlan, last changed 2008-09-02 10:43 by ncoghlan. This issue is now closed.

Files
File name Uploaded Description Edit
meta_subclass_fix.diff ncoghlan, 2008-09-01 10:04 Patch
Messages (3)
msg72222 - (view) Author: Nick Coghlan (ncoghlan) * (Python committer) Date: 2008-09-01 10:04 
Two of the return paths from ABCMeta.__subclasscheck__ store the
subclass being checked in _abc_registry instead of _abc_cache.

The attached patch corrects the issue.
msg72276 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2008-09-01 16:51 
Looks good.
msg72326 - (view) Author: Nick Coghlan (ncoghlan) * (Python committer) Date: 2008-09-02 10:43 
2.6 fixed in r66144, merged to 3.0 in r66147
History
Date User Action Args
2008-09-02 10:43:51ncoghlansetstatus: open -> closed
keywords: patch, patch, needs review
messages: + msg72326
2008-09-02 06:11:31andrewmcnamarasetkeywords: patch, patch, needs review
nosy: + andrewmcnamara
2008-09-01 16:51:52georg.brandlsetkeywords: patch, patch, needs review
resolution: accepted
messages: + msg72276
nosy: + georg.brandl
2008-09-01 10:07:04ncoghlansetpriority: critical -> release blocker
keywords: patch, patch, needs review
2008-09-01 10:04:44ncoghlancreate