➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Compile warning for Objects/stringlib
Type: Stage:
Components: Library (Lib) Versions: Python 3.0
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: christian.heimes, kirkshorts
Priority: normal Keywords: patch

Created on 2008-08-28 13:05 by kirkshorts, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
issue3713.patch kirkshorts, 2008-08-28 13:59 patch to fix pre-processor directives
Messages (3)
msg72087 - (view) Author: Andy (kirkshorts) Date: 2008-08-28 13:05 
Checked out the PY3K branch and built. Received a warning 
about "characters after #ifdef ignored" from Objects/stringlib/find.h

the line in question is:

#ifdef STRINGLIB_WANT_CONTAINS_OBJ && !defined(FROM_BYTEARRAY)

Which is likely to mean that it will not do what is expected.

System is Ubuntu using GCC (otoh can't remember full compiler spec will 
post in later)

Patch to follow that modifies the above line to:

#if defined(STRINGLIB_WANT_CONTAINS_OBJ) && !defined(FROM_BYTEARRAY)

and will change the comment on the closing #endif too.

hope component choice is correct
msg72089 - (view) Author: Andy (kirkshorts) Date: 2008-08-28 13:59 
patch for issue attached.

gcc -v => gcc version 4.2.3 (Ubuntu 4.2.3-2ubuntu7)

tests:

./runtests.sh =>
   0 BAD
 297 GOOD
  27 SKIPPED
 324 total
msg72093 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2008-08-28 14:55 
Thanks! It was a merge glitch. Fixed in r66055
History
Date User Action Args
2022-04-11 14:56:38adminsetgithub: 47963
2008-08-28 14:55:49christian.heimessetstatus: open -> closed
resolution: fixed
messages: + msg72093
nosy: + christian.heimes
2008-08-28 13:59:26kirkshortssetfiles: + issue3713.patch
keywords: + patch
messages: + msg72089
2008-08-28 13:05:06kirkshortscreate